search

groops-devs / groops

A software toolkit for gravity field recovery and GNSS processing
GNU General Public License v3.0
178 stars 106 forks source link

Question about function "void fillSymmetric(MatrixSliceRef A)" #253

Closed MrSoul8715 closed 4 months ago

MrSoul8715 commented 5 months ago

The test condition "i < A.rows()" in the for loop seems to be wrong. The correct test condition may be "i < A.rows()-1". Thanks for reading.

tmayerguerr commented 4 months ago

Hi, You are only partly right: the last loop is indeed not necessary, but does not cause any problems as the zero size copy does nothing. regards Torsten