groops-devs / groops

A software toolkit for gravity field recovery and GNSS processing
GNU General Public License v3.0
170 stars 102 forks source link

official debian package, license problem #29

Closed alexmyczko closed 3 months ago

alexmyczko commented 2 years ago

Trying to create an official package, I encounter many typos, listed here:

https://mentors.debian.net/package/groops/

you might want to fix them?

err figured it can't be distributed commercial, it can't be changed (the parts in source/external)... giving up on an official package

sestras commented 2 years ago

The typos should be fixed with cf59ec6, thanks for notifying us about them.

alexmyczko commented 2 years ago

thanks. is there a chance to change the licensing for the fortran files or replace them with some dfsg compliant license?

tmayerguerr commented 2 years ago

We have tried to reduce the dependencies on external sources as much as possible. The remaining Fortran sources are implementations of specific geopyhsical models and I don't know how to change the license or replace them.

It should be possible to modify GROOPS so that it can be compiled without these models and with reduced functionality. We did similar for some external libraries (Z library, netcdf, erfa) by using #ifdefs in the code, see CMakeLists.txt. I can take a look at it, but definitely not this month. Could this be a way?

regards Torsten

alexmyczko commented 2 years ago

Hmm, it's about these files:

Files: source/external/hwm/*
Copyright: 2014 Douglas Drob <douglas.drob@nrl.navy.mil>
           2008 John Emmert
                Geospace Science and Technology Branch
                Space Science Division, Naval Research Laboratory
                4555 Overlook Ave., Washington, DC 20375
License: CC-BY-NC-ND-4.0
 See https://creativecommons.org/licenses/by-nc-nd/4.0

and

Files: source/external/jb2008
Copyright: 2008 Jacchia & Bruce R Bowman
License: Space-Environment-Technologies-License
 See http://sol.spacenvironment.net/jb2008/License.html

I thought maybe they could be contacted and asked nicely? I'm not sure if the software is still useful removing those specific geophysical models.

tmayerguerr commented 2 years ago

We added the option in CMake to disable some part of the sources, see at the end of INSTALL.md.

The mentioned models HWM and JB2008 are only used for drag modelling for LEO satellites not equipped with an accelerometer. Therefore GNSS processing as well as GRACE/GRACE-FO gravity field processing is fully working without using these models.

Additionally, GROOPS includes two alternative thermospheric models with JB2008 and NRLMSIS. So removing one causes no problems as you can use the other one. The thermospheric wind model HWM14 has only minor impact of the drag modelling and also can be left out easily.

alexmyczko commented 2 years ago

I'm failing to build with: https://sid.ethz.ch/debian/groops/2022/groops_0%2Bgit20220120%2Bds-1_amd64.build

akvas commented 2 years ago

Hi Alex,

the header external/hwm/hwm.h is one of our files (and hence GPLv3), so you do not have to delete it. For a list of files in external/ with non-compatible licenses please check out the corresponding README.

Best regards, Andreas

alexmyczko commented 2 years ago

many thanks :)

alexmyczko commented 1 year ago

just to keep this visible and public, if someone else wants to pick it up:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1001622

alexmyczko commented 11 months ago

so i tried to get groops into non-free, but msis is a problem with:

A user of the Software shall not: (...) (iii) disseminate the Software (...)

can groops still be useful without msis?

tmayerguerr commented 11 months ago

Hi Alex, msis is a thermospheric model and is used to calculate atmospheric drag for low earth orbit (LEO) satellites. It is not needed for full GNSS processing (GNSS satellites orbit outside the thermosphere). GRACE satellites are equipped with an accelerometer and measure atmospheric drag directly. So all important applications work without a thermospheric model. regards Torsten

alexmyczko commented 11 months ago

That is great to know, another chance to get groops easily be installed with apt…

alexmyczko commented 11 months ago

Can we get a switch like DISABLE_NRLMSIS2=TRUE where groops builds without source/external/nrlmsis2 ?

tmayerguerr commented 11 months ago

Have I misunderstood something or have I overlooked something? There should be a DISABLE_NRLMSIS switch.

alexmyczko commented 11 months ago

So sorry, I did not expect that. Will try it… worked like a charm, another round of ftp-master checks. Enjoy the details: https://salsa.debian.org/ftp-team/manpages/-/blob/master/doc/ftp-new.7.man

alexmyczko commented 6 months ago

Thank you https://packages.debian.org/sid/groops now we just need to get rid of non-free

alexmyczko commented 6 months ago

ah licenses incompatibities, is there a way to fix it?

the IERS license is not compatible with GPL-3 and thus the GPL software can be only combined with the IERS software in case it is not modified. This is ok for non-free. But as the IERS license requires for example renaming of modified functions, this software can not be used together with GPL-software in main.

tmayerguerr commented 5 months ago

Same solution?: Compile with DISABLE_IERS.

alexmyczko commented 3 months ago

that worked, it's now part of non-free/groops...