mqtt subscribing to private path had a small bug

groove-x / mqtt_bridge

mqtt_bridge provides a functionality to bridge between ROS and MQTT in bidirectional

MIT License

160 stars 146 forks source link

mqtt subscribing to private path had a small bug #27

Closed kapilPython closed 4 years ago

kapilPython commented 4 years ago

The Topic to which the mqtt is subscribing in MqttToRosBridge is wrong with respect to the condition of private path. It should use the member variable _topic_from because that has the private path extracted topic name.

Minipada commented 4 years ago

Can this be reviewed? It resolves #19

yuma-m commented 4 years ago

Hi @kapilPython,

Thank you for your contribution. Your changes look good, could you kindly confirm the comment I added?