Use rosdep to install python dependencies

groove-x / mqtt_bridge

mqtt_bridge provides a functionality to bridge between ROS and MQTT in bidirectional

MIT License

159 stars 146 forks source link

Use rosdep to install python dependencies #53

Closed Tobias-Fischer closed 3 years ago

Tobias-Fischer commented 3 years ago

In the RoboStack project that combines Conda with ROS we were running into problems building mqtt_bridge because of the custom pip install target. This PR removes this and uses standard rosdep to install the dependencies.

ledmonster commented 3 years ago

@Tobias-Fischer I found python3-msgpack and python3-paho-mqtt in ubuntu package repository. But I can't find python-inject there. Can you resolve this dependency in your envitonment?

Tobias-Fischer commented 3 years ago

Hi, in RoboStack we use conda-forge to manage dependencies, instead of Ubuntu. It works on Ubuntu as well though (and many other Linux distributions, Windows and MacOS), check it out: https://github.com/RoboStack/ros-noetic/pull/113

ledmonster commented 3 years ago

I see. I found python-inject-pip here, so I think that python-inject-pip would be better.

https://github.com/ros/rosdistro/blob/master/rosdep/python.yaml

You can add custom dependency for conda-forge there.

Tobias-Fischer commented 3 years ago

Agreed and fixed @ledmonster