search

groovecoder / discord

GitHub webhook that analyzes pull requests and adds comments about incompatible CSS
Mozilla Public License 2.0
29 stars 13 forks source link

Conditionally include new relic to avoid local errors #129

Closed darkwing closed 9 years ago

darkwing commented 9 years ago

Getting lame test errors locally, as does travis.

darkwing commented 9 years ago

Good call! Updated

darkwing commented 9 years ago

I'm restoring this to its original state. Since the newrelic setup relies on that key, that's what we should check.

openjck commented 9 years ago

Nice! That would definitely get rid of the error. I'm worried, though, that we won't be getting any errors in the logs if the production environment variable is accidentally unset. Is there a way we could hide the errors locally without that risk?

darkwing commented 9 years ago

If it's accidentally unset, newrelic wouldn't work anyway and errors would show up there on prod.

openjck commented 9 years ago

Yeah, that's true. Works for me! Just needs a beautify update.

darkwing commented 9 years ago

Grrrr, updated