Closed openjck closed 9 years ago
@groovecoder: If it's not too much trouble, I would be super interested in what you think, too. :smile:
First review done. Some of them are big-ish things, but we can just discuss them and/or file follow-up issues for them; dont need to fix them all in this PR.
@darkwing - want to take a look at this?
Updated! Only comment not addressed is the tests.js callback hell. Thoughts @darkwing?
I think I'll add promises to sendHookPayload
. That should do the trick.
Decided not to spend too much time on flattening the test out. Ready to go!
When I first pushed this up, I got:
groovecord::DATABASE=> select * from "Pings";
ERROR: relation "Pings" does not exist
LINE 1: select * from "Pings";
Because the migrations don't seem to run automatically. FWIW, my web: ./gulp run
process was idle during the deploy, and is still idle. When I hit https://groovecord.herokuapp.com/, the logs show that un-idling the web process ran the migration when it was needed. So maybe just something to be aware of for future deploys: manually run migrations via heroku run
to be sure.
But, then I got the dreaded ambiguous Application Error of death and the first payload delivery failed. :cry: And I'm having trouble getting detailed log output from the web process?
Strange. I can't reproduce that. Is Postgres installed?
@mrmakeit or @darkwing, does the same thing happen when you follow the steps in the How to spot-check section of the pull request description?
Nevermind. I think I got it.
Luke, can you try again? You'll need to destroy and re-create the database when the web dyno is not running.
heroku ps:scale web=0
heroku addons:destroy heroku-postgresql:hobby-dev
heroku addons:create heroku-postgresql:hobby-dev
heroku ps:scale web=1
WORKS on a fresh app.
groovecord2::DATABASE=> SELECT * FROM "Pings";
id | repo | createdAt | updatedAt
----+--------------------------+----------------------------+----------------------------
1 | groovecoder/discord-test | 2015-08-22 13:13:23.615+00 | 2015-08-22 13:13:23.615+00
(1 row)
Filed https://github.com/mdn/discord/issues/151 as a follow-up.
Reviewing
Definitely go commit-by-commit. It's not that bad, but lots of lines were changed when
config.js
was modified and lots of files were moved when tests were added.Testing
Follow the updated instructions in TESTING.md.
How to spot-check
heroku addons:create heroku-postgresql:hobby-dev
heroku pg:psql
SELECT * FROM "Pings";