search

groovecoder / discord

GitHub webhook that analyzes pull requests and adds comments about incompatible CSS
Mozilla Public License 2.0
29 stars 13 forks source link

Fix #159 #164

Closed Faeranne closed 8 years ago

Faeranne commented 8 years ago

Using express.static should pass requests to /docs to the local /docs folder.

openjck commented 8 years ago

Whoa, awesome! I'll look at this soon.

openjck commented 8 years ago

This hosts TESTING.md, but Firefox prompts me to download the file or choose an application to open it with. Can we render the Markdown like we do with README.md?

We currently use Gulp to convert the Markdown to HTML, but I'm not sure if that will scale now that we need to host multiple Markdown files. Make we can use the marked library together with Nunjucks to render the Markdown-powered pages?

Faeranne commented 8 years ago

Sounds like an option. Gulp can be set up to scale for as many files as we want, so long as we aren't trying to add new files on the live server.

On Fri, Dec 18, 2015, 16:20 John Karahalis notifications@github.com wrote:

This hosts TESTING.md, but Firefox prompts me to download the file or choose an application to open it with. Can we render the Markdown like we do with README.md?

We currently use Gulp to convert the Markdown to HTML, but I'm not sure if that will scale now that we need to host multiple Markdown files. Make we can use the marked library together with Nunjucks to render the Markdown-powered pages?

— Reply to this email directly or view it on GitHub https://github.com/mdn/discord/pull/164#issuecomment-165910265.

Q: Why is this email five sentences or less? A: http://five.sentenc.es

Faeranne commented 8 years ago

Also, gulp would be more efficient with more users.

On Fri, Dec 18, 2015, 16:49 Blixa Morgan blixa@projectmakeit.com wrote:

Sounds like an option. Gulp can be set up to scale for as many files as we want, so long as we aren't trying to add new files on the live server.

On Fri, Dec 18, 2015, 16:20 John Karahalis notifications@github.com wrote:

This hosts TESTING.md, but Firefox prompts me to download the file or choose an application to open it with. Can we render the Markdown like we do with README.md?

We currently use Gulp to convert the Markdown to HTML, but I'm not sure if that will scale now that we need to host multiple Markdown files. Make we can use the marked library together with Nunjucks to render the Markdown-powered pages?

— Reply to this email directly or view it on GitHub https://github.com/mdn/discord/pull/164#issuecomment-165910265.

Q: Why is this email five sentences or less? A: http://five.sentenc.es

Q: Why is this email five sentences or less? A: http://five.sentenc.es

openjck commented 8 years ago

Yeah, Gulp is an option too. Whatever makes it easiest to work with multiple Markdown files.

groovecoder commented 8 years ago

See https://github.com/mdn/discord/issues/159#issuecomment-168236893 ... I think we should close this without fixing ...

groovecoder commented 8 years ago

Closing this without fixing. We shouldn't serve the docs/ files via the website. We should update the home page with a link to GitHub for docs.