groovecoder / discord

GitHub webhook that analyzes pull requests and adds comments about incompatible CSS
Mozilla Public License 2.0
29 stars 13 forks source link

Discord sometimes comments on old, inactive pull requests #166

Open openjck opened 8 years ago

openjck commented 8 years ago

Sometimes, while commenting on a new pull request, Discord will also comment on an old pull request that is completely unrelated. Sometimes this second pull request is from another project.

For example, imagine that the Kuma and Bedrock teams both use Discord. Imagine that one day, the Kuma team opens a pull request. Discord would comment on that pull request normally. Then imagine that the Bedrock team opens their own pull request a few weeks later. Discord would also comment on that pull request normally, but it might also go back and comment on the very old and unrelated Kuma pull request at the same time.

I'm really stumped by this. Discord should only be reacting to pull request activity. Nothing happening in project A should trigger Discord to comment on project B. I'm tempted to say this has something to do with Redis jobs getting stuck, and maybe it does, but I vaguely remember this happening before Redis was introduced.