search

groovecoder / discord

GitHub webhook that analyzes pull requests and adds comments about incompatible CSS
Mozilla Public License 2.0
29 stars 13 forks source link

Clean up extension code #78

Closed darkwing closed 9 years ago

darkwing commented 9 years ago

Some basic cleanups:

  1. We aren't checking for file extension case - fixed.
  2. rawUrl isn't hoisted, and actually doesn't need to exist
  3. else/if -- a file won't be .styl and .css
openjck commented 9 years ago

Awesome! Hate to be a nag, could we do a beautify before merging this?

darkwing commented 9 years ago

No problem, I just didn't know how to do it :/

openjck commented 9 years ago

No problem, it was more difficult than it should have been. I submitted #80 to fix that.

openjck commented 9 years ago

Looks great! Nice improvements. :clap: