groovy / GMavenPlus

A rewrite of GMaven, a Maven plugin for Groovy
Other
285 stars 35 forks source link

Fix debug output of plugin class path #182

Closed TobiX closed 3 years ago

TobiX commented 3 years ago

Just a minor nit: Before, there was no separator between elements, with this naive change there is one too much at the end...

keeganwitt commented 3 years ago

Yea, I guess to be consistent with the other classpaths that are logged, probably this would be better (unfortunately this isn't Java 8, for compatibility, so I don't have String.join(), so it's a bit verbose):

for (int i = 0; i < pluginArtifacts.size(); i++) {
    sb.append(pluginArtifacts.get(i).getFile());
    if (i < pluginArtifacts.size() - 1) {
        sb.append(", ");
    }
}
keeganwitt commented 3 years ago

Thanks for the MR!