search

groovy / GMavenPlus

A rewrite of GMaven, a Maven plugin for Groovy
Other
285 stars 35 forks source link

Remove the outdated documentation #207

Closed zhanhb closed 2 years ago

zhanhb commented 2 years ago

The configuration contained in it is misleading and does not work on the latest version of gplus.

keeganwitt commented 2 years ago

Thanks for the PR! I guess the Git wagon plugin which I use to publish the Maven site must not handle deleted content.

zhanhb commented 2 years ago

I thought it is your intentional function not to delete old files. It seems that wagon-gitsite should be blamed, I'm not sure for the detail reason. Maybe you can work with net.trajano.wagon:wagon-git or org.apache.maven.plugins:maven-scm-publish-plugin instead.

My site: wagon-git: https://github.com/zhanhb/thymeleaf-layout-dialect/blob/2.5.1.RELEASE/thymeleaf-layout-dialect/pom.xml#L305-L331 scm-publish-plugin: https://github.com/zhanhb/thymeleaf-layout-dialect/blob/3.0.0/thymeleaf-layout-dialect/pom.xml#L272-L290

keeganwitt commented 2 years ago

Thanks for the suggestion. I'll look into replacing the plugin. Even if it doesn't work any better, it'll be nice to use something maintained (because the one I'm using now seems to be abandoned).