search

groovy / GMavenPlus

A rewrite of GMaven, a Maven plugin for Groovy
Other
285 stars 35 forks source link

Plugin v 3.0.0 fails with Java 21 and Groovy 4.0.15 #276

Closed jgenoctr closed 1 year ago

jgenoctr commented 1 year ago

When I attempt to use GMavenPlus v 3.0.0 with Groovy 4.0.15 and Java 21, the result is the following failure" [ERROR] Failed to execute goal org.codehaus.gmavenplus:gmavenplus-plugin:3.0.0:compileTests (default) on project connectors: Execution default of goal org.codehaus.gmavenplus:gmavenplus-plugin:3.0.0:compileTests failed: Unrecognized target bytecode: '21'. This check can be skipped with 'skipBytecodeCheck', but this may result in a different target bytecode being used. -> [Help 1]

When I follow the suggestion given above, by adding <skipBytecodeCheck>true</skipBytecodeCheck> to the POM, the result is the following:

[INFO] --- gplus:3.0.0:compileTests (default) @ connectors --- [INFO] Using isolated classloader, without GMavenPlus classpath. [INFO] Using Groovy 4.0.15 to perform compileTests. [ERROR] Your Groovy version (4.0.15) doesn't support compilation. The minimum version of Groovy required is 1.5.0. Skipping compiling.

I also realize that Java 21 was just released.

keeganwitt commented 1 year ago

Ooh, I think you found a logical error in an if condition. I'll get a fix out for this right away. The next release will also include support for Java 21, so you won't need the override. Thanks for reporting this!

jgenoctr commented 1 year ago

My mind is completely blown that you got to this so fast!!!! Big time kudos, because this would have blocked my move to jdk 21 (my tests wouldn't execute). Eclipse appears to be having some issues as well, but that's another story altogether. Thanks a ton for getting to this.