search

groovy / gmaven

Groovy integration for Maven
http://groovy.github.io/gmaven/
Apache License 2.0
51 stars 21 forks source link

Bugfix/ladwlo thread safety fix #22

Open ladwlo opened 4 years ago

ladwlo commented 4 years ago

Fix for issue #21

jdillon commented 4 years ago

FTR its unfortunate that older maven-plugins that are not marked as thread-safe are not adapted in a MT maven-execution to be run by a single thread; I recall there is a deeper problem in the integration that makes it not thread-safe but I don't remember what that is ATM.

And sadly I never use the MT maven because many plugins don't play well with it, so I never run into these problems, but maybe the general ecosystem has improved wrt to the use of --threads.

ladwlo commented 4 years ago

I fully agree. I did observe some suspicious behavior of liquibase plugin and groovy-eclipse-compiler in MT mode as well. Luckily, it seems that the set of maven plugins used in our project works quite well with threads - at least I haven't seen failures of our build process since making the gmaven plugin safe.