search

groovy / groovy-android-gradle-plugin

A Gradle plugin to support the Groovy language for building Android apps
Apache License 2.0
850 stars 116 forks source link

Gradle 6 compatibility. #177

Closed autonomousapps closed 4 years ago

autonomousapps commented 4 years ago

I haven't touched the tests at all (I did try ./gradlew check and got some weird-looking failures). Open to working on those, especially if you have some pointers.

autonomousapps commented 4 years ago

Ideally we can publish a snapshot and I can have someone test it (that I know uses it and is blocked from Gradle 6 due to heavy reliance on Spock tests).

autonomousapps commented 4 years ago

Fixed codenarc issues. Some tests still fail, but I don't understand the plugin well enough to understand yet why.

autonomousapps commented 4 years ago

Some tests are failing because we're no longer removing tasks from the TaskContainer (not allowd in Gradle 6), but instead just disabling them.

Screen Shot 2020-03-20 at 12 41 13 PM
autonomousapps commented 4 years ago

I fixed those unit tests that were failing because tasks are no longer removed, but there are others failing because expected files are not present. These might have to do with the changed AGP version that was part of this PR. I'll consider reverting that and see if the tests pass (which would be easier than updating the plugin to AGP 3.5.0, which is already out of date).

autonomousapps commented 4 years ago

Revering to 3.3.1 did fix most of the remaining failed tests. There's still one failed test; not sure why. Any thoughts?

autonomousapps commented 4 years ago

Remaining unit test fixed, albeit in a less than satisfactory way. As I saw in the commit message, it looks like a bug that I first saw a year ago in AGP/Gradle that causes aar files to not have their variant-specific names. I don't really feel like trying to fix that in the context of this project.

autonomousapps commented 4 years ago

Travis failed, but the check test against the plugin project passed.

autonomousapps commented 4 years ago

Thank you!