groovydev / twitter-bootstrap-grails-plugin

Grails plugin for Twitter Bootstrap CSS framework resources
173 stars 92 forks source link

Old Grails Icons Appearing Since Upgrade #50

Closed ocomsoft closed 11 years ago

ocomsoft commented 12 years ago

We upgraded an application to the 2.1.1 version of the plugin and all of the OLD grails icons appear. Why is this built into the is plugin ? It removes the ability for people to choose to use the icons or not.

nwittstruck commented 12 years ago

We have actually fixed that issue in an older release.. Have you set grails.plugins.twitterbootstrap.fixtaglib to true or false?

ocomsoft commented 12 years ago

I have grails.plugins.twitterbootstrap.fixtaglib = true grails.plugins.twitterbootstrap.defaultBundle = 'bundle_bootstrap' In My config.groovy.

I expect this to fix the g:paginate tags and the g:datePicker, not put in extra CSS from the original main.css

nwittstruck commented 12 years ago

Yes, that shouldn't happen, I am just trying to reproduce the error. So do the icons get away when you set fixtaglib to false?

ocomsoft commented 12 years ago

Yes setting grails.plugins.twitterbootstrap.fixtaglib = false removes the icons but also stops the paginate tag from rendering properly. The css is in the fixtaglib.css

nwittstruck commented 12 years ago

Can you checkout master and try if you still have this issue? Should be fixed now.

ocomsoft commented 11 years ago

The Icons etc are gone. But so are the datepicker corrections.... I simply used the latest grails plugin. Sorry for the delay in getting back to you.

nwittstruck commented 11 years ago

Could you please try the current master version?

ocomsoft commented 11 years ago

Yes that seems right to me. Thanks Nicholas.