search

groovydev / twitter-bootstrap-grails-plugin

Grails plugin for Twitter Bootstrap CSS framework resources
173 stars 92 forks source link

Upgrade to v1.3.0 + TagLib issue #7

Closed dimzava closed 12 years ago

dimzava commented 13 years ago

Hi there,

As far as I can see, currently your plugin uses version 1.2.0 of the bootstrap toolkit. Are there any plans to upgrade it to v1.3.0?

Furthermore, is "grails.plugins.twitterbootstrap.fixtaglib = true" supposed to automatically override the default g.paginate tag? I'm asking because in my case I had to put TwitterBootstrapTagLib.groovy under my app's taglib directory to make it work.

Other than that, thanks for your nice contribution!

Regards, Dimitris

groovydev commented 13 years ago

Plugin was build on bootstrap v1.3.0 (https://github.com/twitter/bootstrap/zipball/v1.3.0). I believe that version signature in bootstrap.css is wrong.

Yes. Configuration "grails.plugins.twitterbootstrap.fixtaglib = true" override g.paginate. What grails version do you use?

dimzava commented 13 years ago

Hello,

Thanks for your prompt reply.

I think there's something wrong with the bootstrap version tagged as v1.3.0 (i.e. the link you sent above). If you download the compiled bootstrap.css from the project's homepage (http://twitter.github.com/bootstrap/1.3.0/bootstrap.css) and compare it with the tagged one (https://github.com/twitter/bootstrap/zipball/v1.3.0) you will see that apart from the version and the date (Bootstrap v1.3.0 and Thu Sep 22 12:52:42 PDT 2011 respectively) there are slight differences in the code per se. I discovered those differences while using your plugin: the fluid layout was not working as advertised (http://twitter.github.com/bootstrap/examples/fluid.html) and had to look deeper into the code. Then I replaced the compiled bootsrap.css in your plugin with the one from the bootstrap home page, and everything worked perfectly.

As for the Grails version, I'm using 2.0.0.M2.

Thanks again for your help. Dimitris

dimzava commented 13 years ago

Sorry, I closed the issue by mistake, so reopened it :)

groovydev commented 13 years ago

It looks that bootstrap v1.3.0 download package has outdated compiled version of bootstrap.css. Other files looks fine. I'm going to bake new plugin with proper file (http://twitter.github.com/bootstrap/1.3.0/bootstrap.css).

Regarding "fixtaglib = true". It was tested with grails v1.3.7 and 2.0.0.M1. I have to take a look at it.

Thanks, K

groovydev commented 13 years ago

Checkout plugin v.1.3.0.9

dimzava commented 13 years ago

Thanks again for the quick response.

OK, that fixed my fluid layout issue, but now the dropwdowns in the top bar don't work :-)

I diff-ed the Javascript files in the plugin one by one with those from http://twitter.github.com/bootstrap/javascript.html and although they are the same version (1.3.0), their contents are not identical.

Replacing the plugin's *.js files with those from http://twitter.github.com/bootstrap/javascript.html, fixed the drop-downs.

As far as the "fixtaglib" is concerned, don't think it makes any difference, but I should mention that I'm using WIndows XP.

Regards, Dimitris

groovydev commented 13 years ago

I've updated all js files from http://twitter.github.com/bootstrap/javascript.html. There was some differences comparing to download package. Checkout v1.3.0.10. I have also added logging. You can use: debug "grails.plugins.twitterbootstrap" to log configuration setting.

dimzava commented 13 years ago

OK, it seems that the latest version solved all problems (except the g:paginate issue of course), thanks!

jimirn commented 12 years ago

I am using Grails 2.0RC3 and g:paginate does not work - g:paginate does not generate bootstrap ul/li-tags.

Config: grails.plugins.twitterbootstrap.fixtaglib = true

Gsp: modules loaded: "bootstrap, bootstrap-fixtaglib"

Log: 2011-12-08 09:50:30,514 [Thread-8] DEBUG twitterbootstrap.BootstrapResources - config: grails.plugins.twitterbootstrap.fixtaglib = true 2011-12-08 09:50:30,515 [Thread-8] DEBUG twitterbootstrap.BootstrapResources - config: grails.plugins.twitterbootstrap.defaultBundle = bundle_bootstrap 2011-12-08 09:50:30,516 [Thread-8] DEBUG twitterbootstrap.BootstrapResources - is lesscss-resources plugin loaded? false 2011-12-08 09:50:30,516 [Thread-8] DEBUG twitterbootstrap.BootstrapResources - is jquery plugin loaded? true

UPDATE: I made a 'grails clean' - it works now

tcrossland commented 12 years ago

Hi,

The g:paginate tag isn't overridden by the plugin (Grails 2.0.0, twitter-bootstrap 1.4.0.12). One workaround is to copy TwitterBootstrapTagLib.groovy to application's taglib.

Thanks for the neat plugin!

groovydev commented 12 years ago

I've moved it to taglib. It looks that it is working with grails 2.0. Checkout version 1.4.0.14.