search

groovydev / twitter-bootstrap-grails-plugin

Grails plugin for Twitter Bootstrap CSS framework resources
173 stars 92 forks source link

Customized LESS Bootstrap functionality broken in 3.1.0 #96

Closed jamesxabregas closed 10 years ago

jamesxabregas commented 10 years ago

Since the upgrade of the plugin to Bootstrap 3.1.0 I have found that the LESS customization of Bootstrap using the recommended method in the documentation no longer works.

I receive an error reading "Error compiling less file" for every single Bootstrap less file.

I have tested this issue on a new project with both Grails 2.3.5 and 2.2.4. I also tested with a clean (un-customized) variables.less as bundled with Bootstrap 3.1.0. I am using the most recent version of the Less Resources plugin (less-resources:1.3.3.2).

Downgrading back to 3.0.3 fixes the issue.

I can provide further details if required.

tcrossland commented 10 years ago

I'm getting the same issue (using lesscss-resources:1.3.3).

legart commented 10 years ago

It looks like the lesscss-resources plugin needs to be updated to support the latest version of Bootstrap :(

marceloverdijk/lesscss-java#43

davydotcom commented 10 years ago

Well the good news is Grails 2.4 is moving to Less-asset-pipeline. should be fine there.

tcrossland commented 10 years ago

I appreciate the asset pipeline plugin, but it's unfortunate that there is now this schism between asset pipeline and the "legacy" resources plugin. So many existing plugins are based on the resources approach and ideally should be revised to work with asset pipeline too. It's all a bit messy.

davydotcom commented 10 years ago

asset-pipeline has been designed to intentionally get as close as possible to these plugins to provide this parity. In this plugins current form it works perfectly. But can clash with plugins like font-awesome.

jamesxabregas commented 10 years ago

It looks like this issue is resolved when using the less-asset-pipeline:1.7.0 plugin. This is because Bootstrap 3.1 required LESS 1.6 or higher. It doesn't appear that the less-resources plugin will be upgraded now that asset-pipline has replaced resources in Grails 2.4.

So anyone still experiencing this issue, upgrade your Grails project to 2.4 and use the less-asset-pipeline plugin instead of less-resources.