Closed gamer-mitsuha closed 4 months ago
Thanks so much for the fix. Can you please add the prefix fix:
to your commit message to follow the conventional commits format.
Example:
fix: update import in chat_completions_ext.ts to address TS compilation error
Thanks so much for the fix. Can you please add the prefix
fix:
to your commit message to follow the conventional commits format.Example:
fix: update import in chat_completions_ext.ts to address TS compilation error
Thanks for the review! Updated the commit message. PTAL?
Particularly, this fixes the error in #19
FYI, I found the fix by checking another file (
streaming.d.ts
) in the same directory, which does not trigger the TS compilation error. (It usesimport { ReadableStream, type Response } from 'groq-sdk/_shims/index';
, note the final index.)Tested this in my local repo, TS compilation succeeded after applying the change.