search

grosenberg / Fluentmark

FluentMark -- Eclipse editor for Markdown content
Eclipse Public License 1.0
38 stars 13 forks source link

Not all colors configurable - difficult for dark theme users #38

Open de-jcup opened 5 years ago

de-jcup commented 5 years ago

I tried to setup colors for dark theme more readable. And changed all entries, but there are some which cannot be changed, see next picture:

image

So please add the missing ones.

Plugin version: 1.2.0.20180807-2118, loaded from eclipse marketplace

Remark: In my own plugins I provide always a "Defaults for dark theme" button and sometimes also a dark.css file. Would be nice ...

grosenberg commented 5 years ago

Is anything more than a dark theme button required?

de-jcup commented 5 years ago

Normally the steps described at https://github.com/de-jcup/eclipse-asciidoctor-editor/issues/60 will bring up correct colors automatically when user start up with dark themes - see comments and code from @vogella (css variant)

This is normally the standard way to provide dark theme colouring in e4 style. But -at least currently - it has problems when you switch between white and dark theme. Dark theme colors where not assigned automatically on switching. So I left my "Defaults for dark theme" button in case of problems...

toniocus commented 3 years ago

Hi @de-jcup

I'm facing the dark theme issue myself, and I've noticed you mention steps for configuring ascii-doctor, so what you are suggesting is to use the same approach to solve this issue, or that if you install ascii-doctor and correct colors in it, it will solve the fluentmark issue ?

thanks in advance, hope this is a work-around :-)

de-jcup commented 3 years ago

Hello @toniocus ,

In my plugins I have always a special "Apply defaults for dark theme" button in color preference pages. This is only a workaround and - i you want to adopt this - you have to implement it by your own - I did this in my plugins when it comes to problems.

But you should also apply the wanted official way and provide a dark css file for your plugin. I am not sure why this is sometimes working and sometimes not - but it's the official way and I think it will work in future "out-of-the-box" - e.g.: https://github.com/de-jcup/eclipse-asciidoctor-editor/blob/master/asciidoctor-editor-plugin/css/dark.css works well

My workaround is a little bit cumbersome, because new colors must always be maintained in dark.css and also in code for button... but it works always...

cpfeiffer commented 1 year ago

That would be super useful. Selected text is currently completely unreadable (black text on black background).

mjmeijer commented 5 months ago

same on OSX, dark theme makes unusable