search

grosser / cia

Central Internal Auditing: Audit model events like update/create/delete + attribute changes + grouped them by transaction, in normalized table layout for easy query access.
12 stars 18 forks source link

CIA::VirtualSourceType is here #4

Closed liulikun closed 11 years ago

liulikun commented 11 years ago

@grosser

liulikun commented 11 years ago

I also removed the validation on :source_type, and :source_id, I think validation on :source is covering them.

grosser commented 11 years ago

we should be testing for what we actually care about: :include => :source works + event.source works

liulikun commented 11 years ago

@grosser It's so hard to get FakeActiveRecord preload working with ActiveRecord 3. Do you have other solutions if we don't use FakeActiveRecord?

grosser commented 11 years ago

I'll poke it a bit, we definetely need an approach that works on all rails versions :)

On Thu, Apr 11, 2013 at 10:47 PM, Likun Liu notifications@github.comwrote:

@grosser https://github.com/grosser It's so hard to get FakeActiveRecord preload working with ActiveRecord 3. Do you have other solutions if we don't use FakeActiveRecord?

— Reply to this email directly or view it on GitHubhttps://github.com/grosser/cia/pull/4#issuecomment-16276959 .

grosser commented 11 years ago

https://github.com/zendesk/zendesk/pull/4207

On Thu, Apr 11, 2013 at 11:04 PM, Michael Grosser <grosser.michael@gmail.com

wrote:

I'll poke it a bit, we definetely need an approach that works on all rails versions :)

On Thu, Apr 11, 2013 at 10:47 PM, Likun Liu notifications@github.comwrote:

@grosser https://github.com/grosser It's so hard to get FakeActiveRecord preload working with ActiveRecord 3. Do you have other solutions if we don't use FakeActiveRecord?

— Reply to this email directly or view it on GitHubhttps://github.com/grosser/cia/pull/4#issuecomment-16276959 .