grosser / preoomkiller

Softly kills your process with SIGTERM before it runs out of memory.
MIT License
73 stars 10 forks source link

Support for StatsD metrics #9

Open crolfe opened 2 years ago

crolfe commented 2 years ago

Something that came up in a discussion with my team the other day is it would be nice to be able to see some metrics that will tell me when preoomkiller has kicked in and does its thing.

StatsD should be a good protocol for this, as it's lightweight (all traffic is via UDP), is well-supported by observability tools/platforms, and it should be easy to integrate as there existing crates. We would require some additional configuration flags (e.g. --statsd-host and --statsd-port), to turn this feature on, but it would be off by default if these are not set.

Is this something this project would be willing to support? If so, I will send a PR.

grosser commented 2 years ago

sounds good! ... might also need --statsd-namespace

On Thu, Jan 13, 2022 at 9:21 AM Colin Rolfe @.***> wrote:

Something that came up in a discussion with my team the other day is it would be nice to be able to see some metrics that will tell me when preoomkiller has kicked in and does its thing.

StatsD should be a good protocol for this, as it's lightweight (all traffic is via UDP), is well-supported by observability tools/platforms, and it should be easy to integrate as there existing crates https://github.com/markstory/rust-statsd. We would require some additional configuration flags (e.g. --statsd-host and --statsd-port), to turn this feature on, but it would be off by default if these are not set.

Is this something this project would be willing to support? If so, I will send a PR.

— Reply to this email directly, view it on GitHub https://github.com/grosser/preoomkiller/issues/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACYZ7Z2ADQBIJRJPQ3XH3UV4CYDANCNFSM5L4N2V6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>