grosser / rspec-instafail

Show failing specs instantly
MIT License
283 stars 34 forks source link

No output after upgrade to 1.0.0 #28

Closed wojtha closed 8 years ago

wojtha commented 8 years ago

No output after upgrade to 1.0.0. Downgrading back to 0.5.0 resolves the issue.

I get the following with version 1.0.0:

$ bundle exec rspec spec/models/demo_spec.rb
Run options:
  include {:focus=>true}
  exclude {:slow=>true, :broken=>true}

All examples were filtered out; ignoring {:focus=>true}

After downgrading back to 0.5.0 I get expected output:

$ bundle exec rspec spec/models/demo_spec.rb
Run options:
  include {:focus=>true}
  exclude {:slow=>true, :broken=>true}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 44819
...........................................

Finished in 1.48 seconds (files took 6.86 seconds to load)
43 examples, 0 failures

RSpec 3.4.4 Ruby 2.3.1 Ubuntu 16.04 64bit ZSH shell with Oh My ZSH plugins

grosser commented 8 years ago

updated it to not force dots by default ... add --format progress # to keep dots appear ... documented in readme, but hard to know when just doing an update ... not sure how to better communicate that ...

wojtha commented 8 years ago

@grosser ok

Maybe you can add post_install_message to gemspec?

post_install_message [RW] A message that gets displayed after the gem is installed. Usage: spec.post_install_message = "Thanks for installing!"

See http://rubygems.rubyforge.org/rubygems-update/Gem/Specification.html

wojtha commented 8 years ago

... and maybe some paragraph in Readme could help as well. A paragraph with clear heading like Instructions for upgrade from 0.5 to 1.0 since the code with comment is really invisible - at least for me. Without your mention I would not see it. When you upgrade such simple gem you usually don't expect that you should reread Readme carefully again...

grosser commented 8 years ago

added a comment at the top ... I'm not a fan of post install messages

On Wed, Jun 8, 2016 at 6:40 AM, Vojtěch Kusý notifications@github.com wrote:

... and maybe some paragraph in Readme could help as well. A paragraph with clear heading like Instructions for upgrade from 0.5 to 1.0 since the code with comment is really invisible - at least for me. Without your mention I would not see it. When you upgrade such simple gem you usually don't expect that you should reread Readme carefully again...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/grosser/rspec-instafail/issues/28#issuecomment-224591929, or mute the thread https://github.com/notifications/unsubscribe/AAAsZ9n2nsysZqjbvrc04IUQlDWxA_g_ks5qJsZkgaJpZM4IwH34 .

wojtha commented 8 years ago

@grosser nice! thx! :star2: