search

grosser / wwtd

WWTD: Travis simulator - faster + no more waiting for build emails
MIT License
366 stars 21 forks source link

Test latest jruby instead of ancient versions #24

Closed deivid-rodriguez closed 9 years ago

deivid-rodriguez commented 9 years ago

I'm trying to get the whole test suite passing locally. This helps and saves me from installing very old versions.

grosser commented 9 years ago

this removes tests for the -18mode logic ... so maybe just skip the test if you don't have it installed ?

deivid-rodriguez commented 9 years ago

this removes tests for the -18mode logic ... so maybe just skip the test if you don't have it installed ?

The thing is I haven't seen any specific logic for this in the code, just some for rbx. Can you point me there? I'd say this is handled by the version manager.

Like in my first PR, I'm not clear about the travis failure. I'd say I need to tell travis to install every required Ruby before running the tests, but if that's the problem, I don't get why the build was previously passing.

grosser commented 9 years ago

https://github.com/grosser/wwtd/blob/master/lib/wwtd/ruby.rb#L107

but yeah it's not really needed anymore and also very simple + the other lines in there are also not tested ... so might as well kill the test for that ...

deivid-rodriguez commented 9 years ago

I addressed your comment and I've also been experimenting with travis. Now at least I can reproduce the failures I get locally. The "--parallel" tests seem very unreliable: they hang, the leave stopped processed and hide any output/errors. Can you reproduce this yourself?

grosser commented 9 years ago

the parallel tests are hard to tame ... maybe increase the sleep if ['TRAVIS']