Adds check for asdf presence

grosser / wwtd

WWTD: Travis simulator - faster + no more waiting for build emails

MIT License

366 stars 21 forks source link

Open idabmat opened 6 years ago

idabmat commented 6 years ago

Hi! Thank you for this gem.

Adding another lovely version manager to the mix: asdf

Unfortunately I was not able to run the test suite on my machine. Making a PR and delegating that job to Travis :crossed_fingers:

grosser commented 6 years ago

idk if the other executable are tested, but if they are can you add a test for asdf too ?

grosser commented 6 years ago

looks about right ... what error do you see when running tests ?

idabmat commented 6 years ago

It took me a while to setup a Docker image that included rvm and the different ruby version. (Vagrant was not an option for me).

The tests just finished running on my machine. I get 2 failures:

jruby-9.2 was not installed
WWTD CLI --parallel runs in parallel because my machine took too long to run the test

grosser commented 6 years ago

I was hoping most of the tests would just work if there are different ruby versions installed locally :(

idabmat commented 6 years ago

:man_facepalming: oh you're right! I didn't think of that. I'll install the different versions and run the test suite locally and report back.