grote / Transportr

Free Public Transport Assistant without Ads or Tracking
https://transportr.app
GNU General Public License v3.0
1.04k stars 188 forks source link

Navitia: Error when searching from or to POIs #424

Closed hoijui closed 4 years ago

hoijui commented 6 years ago

IllegalArgumentException: Unhandled error id: no origin nor destination

I never tried the app before, but the above error is what i get when searching for routes in the vicinity of Granada, Spain. I am a Java dev (though not android (yet)), but i could probably do more testing, if given tips/instructions.

grote commented 6 years ago

Could you please provide more information such as which version of Transportr you are trying and what the exact search is that produces this error?

hoijui commented 6 years ago

i am using transportr 1.1.9

and am looking for: From: Alhambra To: Calle Albaicin, Alhama de Granada

it happened for all locations i tried though, including named, search on map, and current location

grote commented 6 years ago

It looks like it only happens when you choose Points of Interest for planning your trip. As a workaround try choosing actual stations.

You are lucky, this is a bug in the public-transport-enabler library which is pure Java, so you can help here. Check AbstractNavitiaProvider and look for the queryTrips() method. Look and the query it generates and try this in Navitia Playground. There's something wrong in how POIs are passed into the query.

grote commented 6 years ago

@hoijui would be great if you could help with fixing this issue. The AbstractNavitiaProvider is pure Java ;)

ialokim commented 4 years ago

Please follow up on this issue at https://github.com/schildbach/public-transport-enabler/issues/299.