grote / Transportr

Free Public Transport Assistant without Ads or Tracking
https://transportr.app
GNU General Public License v3.0
1.04k stars 188 forks source link

Multiple home/work places #505

Open Matthias84 opened 6 years ago

Matthias84 commented 6 years ago

Acknowledgments Please check the following boxes with an x if they apply:

Is your feature request related to a problem? Please describe. People have often multiple home locations or work places that they need to travel regularly. It would be nice, if the App could manage multiple favourite locations at the home / work folders.

Describe the solution you'd like Menu to add / remove more favourite places.

Describe alternatives you've considered

Additional context

TheLastProject commented 6 years ago

I would like to state my support for this feature. I work at a consultancy company, which means that the company itself is my "main work location", but I am often also assigned to another place to work as "secondary work location". Depending on where it is and how long the travel distance is, there may be cases of being put in a hotel during the weekdays, which makes that hotel my "secondary home".

Having more favourite locations would really help me a lot.

A feel a system like Android uses in the default phone app where you can choose what type of phone number something is for each number, which some sane defaults ("Home", "Work" in this case) and an "Other" and "Custom" option, the last allowing you to give it your own work, would be the best solution here.

photo_2018-08-11_13-38-36

I could possibly look into helping implement this myself, but I do have to state I don't have much spare time myself either, and am still very much a beginner with Android so will need some pointers.

grote commented 6 years ago

Related to #417. New duplicate of #385.

@Matthias84 wrote:

People have often multiple home locations or work places that they need to travel regularly.

@TheLastProject wrote:

I am often also assigned to another place to work as "secondary work location". Depending on where it is and how long the travel distance is, there may be cases of being put in a hotel during the weekdays, which makes that hotel my "secondary home".

Can you please explain why for those cases favorite trips don't help? Or as another alternative, why doesn't temporarily changing the current home and work locations help?

As for the implementation: The current home and work locations are hard-coded. It would be quite a bit of work to make them dynamic and have arbitrarily many. There's some UI challenges to solve there as well. If anybody wants to implement this, please sketch out an implementation and UI plan here first before doing real work. I personally won't implement this.

mccoys commented 6 years ago

I support this change. The reason is that I almost never use itineraries, but rather the "next departures". This means favourites should be not only itineraries but locations as well. Furthermore, I don't use transportation for work only, but for other things (I have 3 work locations anyways).

My suggestion would be to completely remove the work and home favourites, and have an unlimited number of custom favourites instead.

Concerning the UI, I don't see why an unlimited list would cause a problem. Isn't it already possible with itineraries? The fact that home and work locations are hard coded sounds to me like a design flaw (although I haven't seen the code).