search

grote / Transportr

Free Public Transport Assistant without Ads or Tracking
https://transportr.app
GNU General Public License v3.0
1.05k stars 189 forks source link

Problem with belgian train database #766

Closed ZeCracotte closed 11 months ago

ZeCracotte commented 3 years ago

Describe the bug I think the SNCB/NMBS database (trains in Belgium) is not well interpreted : all train codes beginning with S (suburban trains) are not identified as train, so they don't appear in the route search. It's very problematic because a lot of trains in Belgium are S trains.

To Reproduce Steps to reproduce the behavior: Search the route Ottignies to Louvain-la-Neuve, you'll see the app will only propose buses.

Expected behavior The app should propose trains, but it doesn't because all trains for this route are S trains, so they are not seen by the route search. If you go and search departures in Ottignies station, the S trains appear.

Screenshots Route search Screenshot_20210720-030044_Transportr Station search Screenshot_20210720-030121_Transportr

Versions (please complete the following information):

ialokim commented 3 years ago

Thanks for your report, I was able to reproduce it here. This needs some further investigation but is most probably due to the internally used PTE library not interpreting the trains correctly.

Altonss commented 11 months ago

So quick update: we decided to disable SNCB/NMBS (https://github.com/grote/Transportr/pull/884) because this network isn't working anymore due to their API change, see https://github.com/grote/Transportr/issues/840#issuecomment-1419297281. I'll close the issue for now, and if SNCB/NMBS gets supported again in the future we could check if your issue is still there.