grote / Transportr

Free Public Transport Assistant without Ads or Tracking
https://transportr.app
GNU General Public License v3.0
1.05k stars 189 forks source link

Amount of stations to take is wrong #809

Open Babyelefant1312 opened 2 years ago

Babyelefant1312 commented 2 years ago

Describe the bug If you search for a connection betqeen two stations, it will show you always one Station less than actually.

To Reproduce Steps to reproduce the behavior:

  1. Station u osloerstr. Berlin to s Westhafen berlin
  2. it will show 3 stations till arrival, evejthough its @4 Screenshot_20220309-160311_Transportr

Versions (please complete the following information):

mimi89999 commented 2 years ago

I think that it's correct. There is an expandable list of stations between stations. It's 3 stations between departure station and arrival station.

Babyelefant1312 commented 2 years ago

Yes thats true, its possible to see it that way. But due to every other navigation systems it would be less confusing. I mean check on g maps for example. It's different. Cheerio

05.04.2022 19:10:09 Michel Le Bihan @.***>:

I think that it's correct. There is an expandable list of stations between stations. It's 3 stations between departure station and arrival station.

— Reply to this email directly, view it on GitHub[https://github.com/grote/Transportr/issues/809#issuecomment-1089062294], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AYEUUUQIWBB4B3GMJD7QXRDVDRXW5ANCNFSM5QJZ272Q]. You are receiving this because you authored the thread.[Verfolgungsbild][https://github.com/notifications/beacon/AYEUUURYXX6ATCWMLIHXKULVDRXW5A5CNFSM5QJZ2722YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIDU4LFQ.gif]

ialokim commented 2 years ago

Interesting, never noticed that difference between Transportr and other apps. Perhaps rephrasing it like "passing 3 stops" could help making it clearer. Although I'm not sure if that would lead to translation issues (e.g. in German I'm not sure how to express that in a concise way).

Altonss commented 1 year ago

Maybe the simplest way would be to increment it by 1?

ialokim commented 1 year ago

Maybe have a short review of other navigation apps, if its true that all of them handle it differently, I'd agree to change it in Transportr as well.

Altonss commented 1 year ago

Apps (or websites) that handle it differently:

M00NJ commented 8 months ago

I also think incrementing the stop count by 1 is the best solution. All the public transport apps I've used so far count stops this way, which caused some confusion when I switches to Transportr.

4jNsY6fCVqZv commented 8 months ago

For the same connection Öffi prints: "3 intermediate stops".

M00NJ commented 8 months ago

That works too, but the string would be quite long then. Some translations might not even fit in one line. Here is german: "3 dazwischenliegende Haltestellen". Apart from that, I still think '4 stops' is easier to comprehend than '3 intermediate stops'. Also imo it makes sense for a public transport app to go for the simplest and most concise option to display information, because you might be in a hurry after all.

4jNsY6fCVqZv commented 8 months ago

For me, the string in German would be "3 Zwischenstopps".

And from a linguistic point of view, I would also ask whether certain number words should also be written out in Transportr. The rules for this differ depending on the language. This would indeed make the string longer. And in the context of this app, it may be easier to grasp if it says "3" instead of "Three".

4jNsY6fCVqZv commented 8 months ago

1

When I look at my screenshot and the original screenshot, it makes more sense to me that there are "3 intermediate stops".

The arrows next to "3 Haltestellen" and "3 stops" show me that I can tap to reveal the stops that are between my selected start and destination.

The intermediate stops are each displayed in a contrasting grey colour. Just like "3 stops". For me, this is also an indication that the naming should be about the "in-between".

4jNsY6fCVqZv commented 8 months ago

What irritates me, but would probably be an issue of its own, is that the start arrow of the route does not point towards the destination, but even away from it. https://github.com/grote/Transportr/issues/936