search

grote / Transportr

Free Public Transport Assistant without Ads or Tracking
https://transportr.app
GNU General Public License v3.0
1.03k stars 187 forks source link

Cla bot doesn't work well #855

Open Altonss opened 1 year ago

Altonss commented 1 year ago

Describe the bug The Cla bot doesn't detect when users sign the CLA in the PR, this creates huge overhead as we (ping @pt2121) first need a maintainer to commit the username to the file outside of the PR.

Couldn't there be a more straight forward way (automatic), to accept user contributions? I feel like this is slowing down the development...

cc @grote @ialokim

ialokim commented 1 year ago

We had this discussion before at some point, the bot indeed just looks at the file on the master branch. But it does not block merging itself, so if the PR authors add themselves to the file as part of the PR, it will be on master after merging. The only annoying part is that the bot keeps posting the same message, I agree with that.

That said, if you find any other Github bot which works in a better way, feel free to propose it here!

Altonss commented 1 year ago

I will try to search for it, thanks!

grote commented 1 year ago

You can also just disable it and remove the CLA requirement, if you want. Then the app stays with its current license forever.

pt2121 commented 1 year ago

cla-assistant-lite looks promising. Or, let's just remove it?

Altonss commented 3 months ago

Why not just remove it? This article explains why CLAs can be questionable: https://drewdevault.com/2023/07/04/Dont-sign-a-CLA-2.html