Closed Bnyro closed 1 year ago
Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @Bnyro on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. Alternatively, you can add a commit that adds yourself to https://github.com/grote/Transportr/blob/master/.clabot
I noticed there's a crash:
Unfortunately I have really no idea how to fix that, it's already running in a try catch
block so it shouldn't crash the app in theory :/
It looks like there's a memory leak in NetworkProvider#queryTrips
(so from the pte library), but I've no clue how that's related to the SDK / AGP changes.
This doesn't look like a crash, just a resource leak. Sure that's the right stack trace?
I haven't checked what would cause this but I can reproduce it. The app is just ANR with Input dispatching timed out
I've downgraded some library versions now (since they depend on certain versions of each other), seems like we didn't actually require bumping all the versions so up for using Material Design 3.
Anyways it's a bit odd that the androidx.fragment
library just can't be updated due to some issues with the MapBox SDK.
Anyways it's a bit odd that the androidx.fragment library just can't be updated due to some issues with the MapBox SDK.
Yeah, that's not great. From what I heard, we'll move eventually away from MapBox. :crossed_fingers:
Can you tell the bot again that you agree with the CLA?
Hey cla bot, I agree with the CLA :)
Yes, I agree to the CLA ...
Build failed. may be have to update Java version in the workflow?
Looks like there is some problem with the dependency pinning again:
No dependency for integrity assertion 'Android:Sdk:platforms:core-for-system-modules.jar:c6560a19a3d6f4478e35a55e8984efb27866bad46ceb9988315cd80aafd8b352'
Maybe we'd need to update https://github.com/grote/Transportr/blob/master/update-dependency-pinning.sh to exclude that dependency from grade.witness
.
Sounds reasonable. Would you mind suggesting the changes to update-dependency-pinning.sh
needed or just pushing them to my branch?
Edit: never mind - pushed to your branch.
looks like the Java version is good now but we got a new error. from what ialokim suggested, can we try to update the update-dependency-pinning.sh?
I believe we have to change from :platforms:android.jar:
to :platforms:core-for-system-modules.jar:
.
The line should be
./gradlew -q calculateChecksums | grep -Ev "^(Skipping|Verifying)" | grep -Ev "files-2.1:|caches:transforms-3:|:build-tools:core-lambda-stubs.jar:|:platforms:core-for-system-modules.jar:|-linux.jar:" > $WITNESS
Thanks again!
Sounds reasonable. Would you mind suggesting the changes to update-dependency-pinning.sh needed or just pushing them to my branch?
I just pushed to your branch.
lol, failed with another error. I will look into this over the weekend then. Thanks for your patience.
Oh no, not yet an other one, the CI doesn't play in our team this time apparently :-p I will try to figure out the reason by using https://github.com/nektos/act tomorrow (I hope that works), but currently I don't have much of an idea what's causing it
Sorry for the delay - been slammed at work. I will re-test and merge over this coming weekend unless anyone wants to review.
closes #869