Release 2.2.0 - Githubissues

ialokim commented 10 months ago

Here are the steps to follow when preparing a new release (some custom tasks added for this release). Please check the following boxes with an x when done:

[x] update PTE to the latest commit at opentransitmap and run ./update-dependency-pinning.sh
[x] re-enable SBB (Switzerland) with new data source #768
[x] ~~re-enable PL (Poland) with new data source https://gitlab.com/opentransitmap/public-transport-enabler/-/commit/693d84e340f1525366e6b29a32c0a81401f326ff~~ (needs more investigation as to which area is actually covered)
[x] test the app (automatically using AndroidTest as well as manually), paying special attention to changes since the last release
[x] fix any bugs if necessary
[x] update translations from Transifex using tx pull --mode=developer -a in the root folder (you need proper permissions to do that)
[x] add newly supported languages to the two arrays in app/src/main/res/values/arrays.xml
[x] revise the commits to master since the last release and add interesting changes (as well as new languages) to the changelog at app/src/main/res/xml/changelog_master.xml, then run python3 ./fastlane/generate_changelog.py
[x] bump the versionCode and versionName in app/build.gradle
[ ] re-enable Transportr for inclusion in F-Droid #826
[ ] file another PR updating all dependencies which should be merged after the successful release

Please also refer to #689 as an example.

ialokim commented 10 months ago

[x] fix any bugs if necessary

several issues reported: #889 #890 https://gitlab.com/opentransitmap/public-transport-enabler/-/issues/6

In order to get the release out soon, I'd consider them as being non-release-blocking.

Altonss commented 10 months ago

[x] fix any bugs if necessary

several issues reported: #889 #890 https://gitlab.com/opentransitmap/public-transport-enabler/-/issues/6

In order to get the release out soon, I'd consider them as being non-release-blocking.

Indeed, #889 and #890 don't seem to be new issues related to this release.

M00NJ commented 10 months ago

Could #872 be a part of this release as well?

ialokim commented 10 months ago

Could #872 be a part of this release as well?

I don't think this is a good idea, given that we want to publish the release soon, and #872 brings a lot of UI changes that need a thourough testing.

Altonss commented 10 months ago

Tested this 2.2.0 release branch, and didn't encounter any issue! Great job @ialokim :clap: I think the new version could be released soon :)

Altonss commented 10 months ago

For the changelog I suggest something like:

- Switch to new map library (maplibre).
- Fix bugs: remember preferred means of transport, fix blank `About > Libraries` page.
- Update PTE data library: transport networks fixes and removals.
- Remove following networks: Finland, Portugal, Hungary, Czech Republic, Ghana, California, Oregon, New York, Ontario, Quebec, British Colombia, Costa Rica, Nicaragua, Florianópolis (Brazil), Brazil, New Zealand.
- Disable temporarily broken endpoints: VOR, STV, VVV and WienerLinien (Austria), Belgium, 9292 (Netherlands).

mesinger commented 9 months ago

@ialokim any way i can help to get this release done?

ialokim commented 9 months ago

Thanks for your review @Altonss!

* [ ]  Why updating strings for pl network navitia that is for now removed? IMHO it clutters a bit the PR with useless strings.

There are a lot of leftover strings from now removed regions which should probably be cleaned properly at some point. But you are right, those are unfortunately really useless. I've removed them now manually.

* [ ]  Shouldn't we also mention in the changelogs that we've re-added VRS?

Good catch, added that!

Altonss commented 9 months ago

Ready to merge and tag the release?

grote commented 8 months ago

Thanks everyone who contributed to this release. You are awesome! :D

I just pressed the button and the release is out. However, Google Play doesn't accept it: Google Api Error: Invalid request - Target SDK of artifact is too low: 124. It seems it is currently 32 which won't work anymore. Please see https://support.google.com/googleplay/android-developer/answer/11926878 for details.

Altonss commented 8 months ago

I just pressed the button and the release is out. However, Google Play doesn't accept it: Google Api Error: Invalid request - Target SDK of artifact is too low: 124. It seems it is currently 32 which won't work anymore. Please see https://support.google.com/googleplay/android-developer/answer/11926878 for details.

That shouldn't be too hard to fix, I'll try to do it :)

Altonss commented 8 months ago

@grote Target SDK issue should be fixed with #910

grote / Transportr

Release 2.2.0 #888