search

grote / Transportr

Free Public Transport Assistant without Ads or Tracking
https://transportr.app
GNU General Public License v3.0
1.02k stars 185 forks source link

Bottom trip banner can disappear after swipe down of trip details view #897

Open Altonss opened 7 months ago

Altonss commented 7 months ago

Describe the bug The bottom trip banner can disappear after swipe down of trip details view, leaving the screen with only a blank banner at the bottom, without a possibility to bring up the trip details again.

To Reproduce

  1. Click on a specific trip to show the detailed view.
  2. Swipe down the details to show the map.
  3. Repeat these swipes several times completely (reducing trip info to bottom banner).
  4. See error: sometimes the banner becomes blank, leaving no other possibility then to go back.

Expected behavior Do not leave the bottom banner blank.

Screenshots image

Versions (please complete the following information):

newhinton commented 5 months ago

The culprit is likely the handling of bottom-sheets. It also applies to the activity_map bottom sheet, aswell as the fragment_trip_detail bottom sheet.

In the TripDetailFragment, the bottomsheet can be closed by swiping down the topBar. When swiping down any other element, it collapses properly.

I think they are not meant to be used in this way. They have a behavior_hideable attribute, but if they are set to false, the bottom sheets dont resize and always take their full space, which is also unwanted.