search

grote / Transportr

Free Public Transport Assistant without Ads or Tracking
https://transportr.app
GNU General Public License v3.0
1.02k stars 185 forks source link

update kotlin to 1.8.22, replace deprecated kotlin synthetics with jetpack bindings #902

Open mesinger opened 6 months ago

mesinger commented 6 months ago

Updates Kotlin to 1.8.22 and migrates the deprecated kotlin synthetics by jetpack bindings as described here

Done

ℹī¸ I did this because I tried to get the project running on my machine and some solution was bumping kotlin.

cla-bot[bot] commented 6 months ago

Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @mesinger on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. Alternatively, you can add a commit that adds yourself to https://github.com/grote/Transportr/blob/master/.clabot

mesinger commented 6 months ago

Hey quick side context why i did this PR,

I really like Transportr and there is a specific feature I'd love it to have, so i checked the repo/issues and jadajadajada... to keep the story short I have read about the slow development speed stuff...

So today I tried to setup my local dev environment and this PR was the result of it. ...

Furthermore I was thinking of the possibility of contributing to this app, despite the fact of knowing the infrequent development the last couple of years and investing time in the onboarding of a dev to a project that lacks invested time anyway is 💀.

As @Altonss and @ialokim you seem to be the most recent contributors, see any sense in further cotributing to Transportr?

My Background: Full Stack SWE, lot of Java experience and some rusty Kotlin. Did some Android dev at Uni 7 years ago so I know the basics. Some CI/CD (also github-actions ✅) knowledge from my work context (which is mostly Spring-Boot apps stuff). So I'm confident I could work on most of the code base on my own, but have no clue on things like getting apps to PlayStore/F-Droid stuff like that.

Greetings

EDIT: The feature I'd like to have in Transportr mentioned above, i did a poc here. Feel free to give your feedback to that also.

Altonss commented 6 months ago

Hey quick side context why i did this PR,

I really like Transportr and there is a specific feature I'd love it to have, so i checked the repo/issues and jadajadajada... to keep the story short I have read about the slow development speed stuff...

So today I tried to setup my local dev environment and this PR was the result of it. ...

Hello @mesinger, I'm happy to read your message! Don't hesitate to open an issue about your feature request :) As for the development setup, I can build Transportr without any issues in Android Studio :thinking:

Furthermore I was thinking of the possibility of contributing to this app, despite the fact of knowing the infrequent development the last couple of years and investing time in the onboarding of a dev to a project that lacks invested time anyway is 💀.

As @Altonss and @ialokim you seem to be the most recent contributors, see any sense in further cotributing to Transportr?

My Background: Full Stack SWE, lot of Java experience and some rusty Kotlin. Did some Android dev at Uni 7 years ago so I know the basics. Some CI/CD (also github-actions ✅) knowledge from my work context (which is mostly Spring-Boot apps stuff). So I'm confident I could work on most of the code base on my own, but have no clue on things like getting apps to PlayStore/F-Droid stuff like that.

Greetings

EDIT: The feature I'd like to have in Transportr mentioned above, i did a poc here. Feel free to give your feedback to that also.

Personnaly I find Transportr really useful and would be happy to see this software maintained in the future :) Some things just require basic maintenance, while some new features would require major developments. For now I focus on maintenance, but I'm open for more bigger changes :)

ialokim commented 6 months ago

Thank you for this PR and welcome to the small community! :) Indeed it would be great to get more contributors for Transportr, so we are happy to have you here!

This sounds like a fix for #737 and I will happily review it once the next release #888 is out.

mesinger commented 6 months ago

Happy to hear that. Do you have any way to communicate besides github e.g. Discord?

mesinger commented 5 months ago

ping: please review this pr