Material Design 3 migration (V2)

[newhinton]

Closes #872

This PR is based on, and superseeds @Bnyro 's Material 3 implementation. It takes the UI a step further, and makes heavy use of the Material You colors.

This was implemented and improved with @Bnyro support, consent and collaboration.

Edit: For more info about what this pr does, look in this discussion: https://github.com/Bnyro/Transportr/pull/1

[newhinton]

I agree to the CLA

[newhinton]

Todo:

~In the trip detail view, warnings/notes are no longer colored in the warning color~

[michaelblyons]

Spelled your name wrong in the JSON file.

[newhinton]

ed81b76099358abe4ec3c6984baae78364bf6915 adds better transitions to the details view, which should improve UX by quite a bit.

If it would work properly. Currently the view is jumping around quite a bit (by switching states from middle back to full) but i dont know why. Generally speaking the transitions are a lot nicer than before. Any help is appreciated!

[newhinton]

Known issues:

• Select Location from main searchbar, dismiss bottom sheet. Re-select location. Left side of bottom sheet has padding
• Drop shadow of navigation also has padding after above flow
• Navigation Drawer is invisible below status bar when opened
• Three State Bottom Sheet has buggy behaviour
• Select Location on map. Start navigation via FAB. New Activity has favorite locations instead of empty list (already present in 2.2.1)
• ~Trip Details toolbar menu does not show up~

[ialokim]

Thanks @newhinton and @Bnyro! The screenshots in the linked PR already look very promising!

I will try to test your changes in the coming days and provide some initial feedback.

[ialokim]

• Select Location from main searchbar, dismiss bottom sheet. Re-select location. Left side of bottom sheet has padding

I haven't encountered that one.

• Drop shadow of navigation also has padding after above flow
• Navigation Drawer is invisible below status bar when opened
• Three State Bottom Sheet has buggy behaviour

But those ones yes.

• Select Location on map. Start navigation via FAB. New Activity has favorite locations instead of empty list (already present in 2.2.1)

Given this is not a regression, I wouldn't further consider it for this PR.

• ~Trip Details toolbar menu does not show up~

This one still happens here.

[ialokim]

Additionally, I've found the following issues while testing:

• Text color looks strange when selected via Material You:

  

• Issues with transport mode selection: not MD3 dialog, icon alignment

  

• DatePicker dialog has different shape

  

• map attribution is partly covered by "home screen bar"

  

• I don't think the back button needs to be as prominent, I'd just leave it in the onSurface color:

  

• text color issue on network selection page, also unnecessary high top bar

  

• invisible icons in several places of the app

  

[ialokim]

This definitely needs some more cleanup work, but I do think this is going into the right direction!

Personally, I'm not fully convinced on giving up on the nice Transportr red altogether, given that it's part of the branding, but it seems that's what Material You is suggesting to do?

[Bnyro]

Personally, I'm not fully convinced on giving up on the nice Transportr red altogether, given that it's part of the branding, but it seems that's what Material You is suggesting to do?

Yes, it does. It would be possible to add s preference to toggle the red vs material you colors though.

[Altonss]

Personally, I'm not fully convinced on giving up on the nice Transportr red altogether, given that it's part of the branding, but it seems that's what Material You is suggesting to do?

+1 for trying to keep the Transportr red identity by default if possible :)

[michaelblyons]

It would be possible to add a preference to toggle the red vs Material You colors though.

I think this is what Trail Sense is doing.

[newhinton]

DatePicker dialog has different shape

This is actually not a regression, it is also present in the current design. It is just a bit more visible in this PR.

Personally, I'm not fully convinced on giving up on the nice Transportr red altogether, given that it's part of the branding, but it seems that's what Material You is suggesting to do?

Yes it is. Though i recommend not to introduce a toggle ability, it would require quite a bit of code to make it work properly. It will lead to bugs. And i don't think i want to spend time on implementing that, especially since there is still a bit to do with the base-proposal.

[newhinton]

Todo:

• [x] Work through code annotations
• [x] Popup Menu - no icons
• [x] Network-Selection coloring
• [x] Mapview Backbutton
• [x] Map-attribution behind bottombar
• [x] transport mode selection dialog theme
• [ ] Select Location from main searchbar, dismiss bottom sheet. Re-select location. Left side of bottom sheet has padding
• [ ] Drop shadow of navigation also has padding after above flow
• [ ] Navigation Drawer is invisible below status bar when opened
• [ ] Three State Bottom Sheet has buggy behaviour
• [ ] Trip Details toolbar menu does not show up

i dont think its a Todo:

• [ ] Datepicker-style
• [ ] Select Location on map. Start navigation via FAB. New Activity has favorite locations instead of empty list (already present in 2.2.1)

[newhinton]

@ialokim @Altonss

I have improved on many of the things you noted. However, there are still some things broken, like the three-state-bottomsheet.

I also found that some issues are very likely due to older libraries beeing used. That opened an entire different can of worms. As an example: I have tried to manually calculate the statusbar height so that i can adjust the backButton in the tripview, with less than optimal results. In newer libraries there is an enableEdgeToEdge() function for Activity. I tried updating the dependency, but that also requires an update to kotlin, which deprecates kotlin-android-extensions which means that we have to switch to viewbindings.

This is rapidly exploding the size of this PR, but i also don't think that we should continue without upgrading the libraries, which are at this point 2-4 years old and up to 5 versions behind.

How should i continue?

[Altonss]

@ialokim @Altonss

I have improved on many of the things you noted. However, there are still some things broken, like the three-state-bottomsheet.

I also found that some issues are very likely due to older libraries beeing used. That opened an entire different can of worms. As an example: I have tried to manually calculate the statusbar height so that i can adjust the backButton in the tripview, with less than optimal results. In newer libraries there is an enableEdgeToEdge() function for Activity. I tried updating the dependency, but that also requires an update to kotlin, which deprecates kotlin-android-extensions which means that we have to switch to viewbindings.

This is rapidly exploding the size of this PR, but i also don't think that we should continue without upgrading the libraries, which are at this point 2-4 years old and up to 5 versions behind.

How should i continue?

I think #902 is a step in the right direction regarding the issues you mentionned. We just need to review/merge it :)