grote / Transportr

Free Public Transport Assistant without Ads or Tracking
https://transportr.app
GNU General Public License v3.0
1.02k stars 184 forks source link

BEG (BayernProvider) has wrong/missing description #934

Open BloodPawHD opened 5 months ago

BloodPawHD commented 5 months ago

Describe the bug I opened an issue in the public-tranport-enabler repo (https://github.com/schildbach/public-transport-enabler/issues/560) because of a bug in the MVV network and developer Schildbach reminds me to use the BayernProvider instead, because it works for Bavaria, that means for Munich, too. BayernProvider is the public-transport-enabler implementation of DEFAS, which is the public transport system of Bavaria (https://www.bayerninfo.de/en/about-bayerninfo-1/data-offer/public-transport-data). The Problem is that this isn't really intuitive, because the description in "app/src/main/res/values/strings.xml" line 322 is just "Bavaria, Würzburg, Regensburg". Users like me maybe think it's just for the area Würzburg and Regensburg and use worse Providers like MVV for Munich. Maybe it's time to drop the support of MVV and other Providers that are already covered in BayernProvider, but I already mentioned this in the public-transport-enabler issue.

Expected behavior Idk but something like "Most of Germany" as in the Deutsche Bahn provider, for example "Most of Bavaria" or "Includes AVV, VAB, VLC, DING, VGI, VVM, MVV, VGN, VLP, RVV, VGRI, bodo, RMV, OAM, VRN, SVV, VVT" ( a whole list of transport networks supported by DEFAS are listed in their PDF https://www.bayern-fahrplan.de/de/de/media/files/liniennetzplan-2024.pdf).

M00NJ commented 2 months ago

After the MVV provider being completely broken the PR for changing the endpoints is now finally being merged. This will also bring real time data to the MVV network. There is also an advantage to a provider that covers a smaller area, since you get fewer suggestions when searching a location. Just look up "Marienplatz" with the BEG provider. There are 45 suggestions when I only need 1 since I live in Munich. So I'm against dropping the MVV provider. But changing the description makes sense.