search

grote / osm2gtfs

Turn OpenStreetMap data and schedule information into GTFS
GNU General Public License v3.0
98 stars 31 forks source link

Upgrade to last Transitfeed #122

Closed prhod closed 6 years ago

grote commented 6 years ago

Wow, that is strange! Suddenly everything works!???

However, before upgrading, we should remove the feed-info workaround at least.

prhod commented 6 years ago

The actual test only check for the size of the file, so there could still be something. I'm adding the do not merge label until I add a test on the OSM relation I noticed before. Sorry for the too early PR !

prhod commented 6 years ago

I added a manual diff on stop_times (to have more explicit messages) and found the bug. It was not related to the upgrade of TransitFeed ! cheers to @nlehuby who told me what the bug could be by reading the code for 10 minutes when I struggled for hours ;)

grote commented 6 years ago

Thanks @prhod!

Could you please also remove the feed_info workaround for this to get merged? It is essentially just reverting 7101a1f3f07629eabe3b77ac286bc5baf1c4572a.

prhod commented 6 years ago

Sorry for the delay, I made the revert :)