search

grote / osm2gtfs

Turn OpenStreetMap data and schedule information into GTFS
GNU General Public License v3.0
99 stars 31 forks source link

Add support for required via tag (if given inside OSM data) #129

Closed ialokim closed 6 years ago

ialokim commented 6 years ago

This PR adds support for the required via tag if it is set in the OSM data.

After merging in #126, this PR should be rebased and we should change the verification check introduced there by adding the via tag.

Fixes #101.

pantierra commented 6 years ago

I was first hesitating about the via tag, as it doesn't seem to be an official tag in OpenStreetMap. However it is mentioned in the wiki, part of the approved proposal, and it is used quite extensively. So, all good, to include it into the osm2gtfs core. It looks good so far. Will wait until #126 got in until I test it thoroughly.

ialokim commented 6 years ago

I've only rebased and made pep8 happy :laughing:

ialokim commented 6 years ago

Before merging this, we should check all the creators' GTFSes, because of the new required information in the schedule file. I had to fix Esteli's schedule accordingly.

pantierra commented 6 years ago

I guess the tests (#133, #135, #136 and #137) will be very useful for this.

grote commented 6 years ago

Thanks @ialokim!