search

grote / osm2gtfs

Turn OpenStreetMap data and schedule information into GTFS
GNU General Public License v3.0
98 stars 31 forks source link

Add support for national buses and ferries of Nicaragua #130

Open ialokim opened 6 years ago

ialokim commented 6 years ago

This PR only adds the minimal config.json used by the standard creators. However, to successfully produce the countrywide GTFS, it depends on #114, #124, #125, #126 and (to clean the data up) on #127.

Those PRs should be merged first.

pantierra commented 6 years ago

Yeah, nice progress here! I would like to see #83 going in before also. This list of providers is getting long now.

ialokim commented 6 years ago

I've changed the configuration to allow ferries, too (simply removed route=bus). So now, the ferries from and to Ometepe (e.g. this one) are available inside the resulting GTFS.

pantierra commented 6 years ago

This PR needs to be rebased on the latest commits to the code and modified to stick to the newly introduced naming conventions (see #83 for more information) for selectors.

ialokim commented 6 years ago

This PR needs to be rebased on the latest commits to the code and modified to stick to the newly introduced naming conventions (see #83 for more information) for selectors.

Done. I've renamed the selector to ni_national as suggested in #83.

pantierra commented 6 years ago

I suggest to include tests for this provider first. Based on the structure of #133 it's quite easy to create them (see #136).

grote commented 6 years ago

@xamanu so you don't want to have this merged until there's tests for it?

pantierra commented 6 years ago

In case #136 gets merged in, I'd be happy to provide the missing tests here. Just waiting for the direction we are taking there.