search

grote / osm2gtfs

Turn OpenStreetMap data and schedule information into GTFS
GNU General Public License v3.0
98 stars 31 forks source link

Add acceptance tests for Gran Area Metropolitana, Costa Rica #137

Closed pantierra closed 4 years ago

pantierra commented 6 years ago

This PR is based on #134. It introduces a non-regression, acceptance tests for the Costa Rican provider. A review of the owner of the creator (@jamescr) is highly appreciated and a precondition to get this merged in.

pantierra commented 6 years ago

Updated based on latest upstream. Now this PR only includes the respective commit and is easier to review, for your convenience.

grote commented 6 years ago

@jamescr somebody nice made tests for your creator :) Do you want to review them?

pantierra commented 6 years ago

Rebased on current master.

pantierra commented 4 years ago

The related improvements for the Costa Rica (Gran Area Metropolitana) Creator have been applied (#158) and changes to the tests, provided by @jamescr are included here. Let's see the tests going through and this should be ready to go in.

pantierra commented 4 years ago

This PR still needs a review. Can anybody please approve? Then we can merge it in and have all creators covered by tests :tada:

jamescr commented 4 years ago

@xamanu thanks!

nlehuby commented 4 years ago

I will make a review