search

grote / osm2gtfs

Turn OpenStreetMap data and schedule information into GTFS
GNU General Public License v3.0
99 stars 31 forks source link

Incomplete shapes because of roundabout #161

Open nlehuby opened 4 years ago

nlehuby commented 4 years ago

In OpenStreetMap, it is very common to have roundabout represented as a unique closed way. This roundabout may then be used as part as bus route relations.

Even if it is cleaner to cut the roundabout in separate ways at each relevant intersection to have a continuous bus route, using a closed way of the entire roundabout in the relation is usually not considered an error in OpenStreetMap.

But osm2gtfs does fail to generate the shape because of the closed way.

For instance, for this bus route image

the shape generated is cut at the first un-cut roundabout met: image

A valid fix would be to ignore and skip closed way on the shape building.

nlehuby commented 4 years ago

I have a fix ready: image

https://github.com/Jungle-Bus/osm2gtfs/compare/python3...Jungle-Bus:fix_shapes

But we need to merge #160 first :wink: