groton-school / knowledgebase

Knowledgebase website
https://kb.groton.org
GNU General Public License v3.0
0 stars 0 forks source link

Blocking Google Analytics breaks script #19

Closed battis closed 9 months ago

battis commented 10 months ago

It's a bit of a thread race condition. But much of the time, if the Google Analytics script can't be loaded (perhaps because a developer is using Block Yourself from Analytics), it causes subsequent portions of the script to fail (e.g. re-coloring buttons to match links).

battis commented 9 months ago

Resolved in https://github.com/groton-school/knowledgebase/commit/aa7bc7e82584504af5ada83b0aaba69421afaa10