search

grottohub / glyph

A purely Gleam Discord library built from the ground up with stratus.
24 stars 4 forks source link

Fix/message create event #13

Open dixtel opened 3 months ago

dixtel commented 3 months ago

@grottohub I see that you merged a lot of things to main and it will not be so easy to merge with my changes. In short my changes are about:

grottohub commented 3 months ago

great! ill take a look through this today, but as its a bit sizable and ill need to think about merge strategy, might not have full feedback until tomorrow

dixtel commented 3 months ago

@grottohub I will fix these issues today or tomorrow

dixtel commented 3 months ago

@grottohub I fixed these conflicts. In this week I will not have time for gleam/glyph :disappointed:

I'm really want to finish glyph_codegen because right now the conversion between field type to dynamic.* is hard-coded (e.g. Option(String) => dynamic.optional_field(dynamic.string)) and I don't like it. This will cause errors for field types not supported in glyph_codegen (This can happen when merging this MR)

I want to create generic codegen for json that accept any field type and share with the gleam community.