search

groue / GRDB.swift

A toolkit for SQLite databases, with a focus on application development
MIT License
6.61k stars 677 forks source link

podspec is not including the Privacy manifest #1504

Closed manahilov closed 4 months ago

manahilov commented 4 months ago

Currently the GRDB.swift.podspec, does not include the Privacy manifest, so if we use the framework via CocoaPods, the latest version 6.25.0 lands without the Privacy manifest.

I guess it should be included something like for both standard and SQLCipher: ss.resource_bundles = {'GRDB.swift' => ['GRDB/PrivacyInfo.xcprivacy']}

groue commented 4 months ago

Hello @manahilov,

Yes, the pull request that introduced the manifest did not include this file as a resource in the podspec. See this commit message for the two reasons behind this decision: https://github.com/groue/GRDB.swift/commit/bbe7d2f1cab35945b4f35cb26622e804146cfd78

Particularly, the privacy manifest was added in GRDB 6.25.0, when 6.24.1 is the latest version that could be published as a CocoaPods. Subsequent versions can not be published due to https://github.com/CocoaPods/CocoaPods/issues/11839. Please raise your concern in this linked issue if you regret this situation.

Consequently, in the current state of my knowledge, there's no way to add this privacy manifest to GRDB via CocoaPods. This has no consequence on your applications: GRDB does not collect anything.

groue commented 4 months ago

I'm closing the issue. Please reopen when both concerns expressed in https://github.com/groue/GRDB.swift/commit/bbe7d2f1cab35945b4f35cb26622e804146cfd78 can be resolved.

manahilov commented 4 months ago

Thank you for the prompt answer. I think if you use resource_bundles instead of resource it will do the work, at least that's my experience with other SDKs that I support. Regarding the Cocopoads issue I am sorry to hear that publishing is not working as expected.

I can use SPM instead of CocoaPods, but is there a way to use the SPM with GRDB.swift/SQLCipher just like in CocoaPods?

groue commented 4 months ago

I think if you use resource_bundles instead of resource it will do the work, at least that's my experience with other SDKs that I support.

Oh, thank you for this hint! It should indeed avoid messing up with app resources 👍

Regarding the Cocopoads issue I am sorry to hear that publishing is not working as expected.

So am I...

I can use SPM instead of CocoaPods, but is there a way to use the SPM with GRDB.swift/SQLCipher just like in CocoaPods?

Not trivially. Some people share their experiences in https://github.com/groue/GRDB.swift/discussions/1495, the discussion I have specifically opened for SQLCipher users in the context of interrupted CocoaPods support.