search

groue / GRMustache.swift

Flexible Mustache templates for Swift
http://mustache.github.com/
MIT License
594 stars 155 forks source link

Fix runtime crash in Xcode 10 #53

Closed ainopara closed 5 years ago

ainopara commented 6 years ago 
Attempted to read an unowned reference but the object was already deallocated

MustacheBox.render should be a method calling, since renderImpl can not guarantee self is retained when called. Detail: https://bugs.swift.org/browse/SR-8206

master-nevi commented 5 years ago

Confirmed this fixes the issue.

edwardaux commented 5 years ago

@groue any chance this could be merged? Crashes galore without it... thanks a lot.

sburlewapg commented 5 years ago

@groue is this still being maintained?

fumito-ito commented 5 years ago

merged as #57 . thanks!