Upgrade swift version to Swift 5 and some fixes

groue / GRMustache.swift

Flexible Mustache templates for Swift

http://mustache.github.com/

MIT License

594 stars 155 forks source link

Upgrade swift version to Swift 5 and some fixes #57

Closed fumito-ito closed 5 years ago

fumito-ito commented 5 years ago

This PR offers following updates.

upgrade swift to Swift 5
fix runtime crash on Xcode 10 via https://github.com/groue/GRMustache.swift/pull/53
remove invalid tests for Swift via https://github.com/groue/GRMustache.swift/pull/39

sburlewapg commented 5 years ago

Thank you for doing this!! @groue can this get merged if everything looks fine?

groue commented 5 years ago

Hello @fumito-ito,

I gave a look at your PR, and it looks fine to me. I also see that you did already support Swift 4.0 and Swift 4.2 in the past. Thank you very much for your support and dedication :-)

I have invited you as a repository contributor. Feel right at home: I give you the keys 🤝🎁🔑. Feel free to update and change the code, close issues, merge pull requests, and release new versions!

Please also send me the email you would like to use for pod trunk push!

groue commented 5 years ago

PS: I don't feel like maintaining GRMustache.swift these days, as you have noticed. But if you have any question I will do my best transmitting any useful information.

eight-molecules commented 5 years ago

@groue thanks for keeping this going by passing off some responsibility, and @fumito-ito thanks for taking up the slack here!

groue commented 5 years ago

It was a long overdue. I owe apologies to everyone. Thank you all for your patience!