tvOS Support - Githubissues

groue / GRMustache

Flexible and production-ready Mustache templates for MacOS Cocoa and iOS

http://mustache.github.com/

MIT License

1.44k stars 190 forks source link

tvOS Support #101

Open aaronbrethorst opened 9 years ago

aaronbrethorst commented 9 years ago

I'm not sure what your requirements are for adding a new operating system to GRMustache, but I wanted to start a conversation with you about adding tvOS support to the project. I'm using GRMustache an app for tvOS, and would love to have support officially included so I don't have to work about tracking patches. Let me know what else I need to do!

Add a tvOS target to the xcodeproj and rules to the makefile to build a tvOS-compatible library.
Enable Bitcode for iOS and tvOS (it's required on tvOS)

groue commented 9 years ago

Hello @aaronbrethorst, I'd be glad having GRMustache running on tvOS, for sure :-)

I'm currently, on my spare time, moving GRMustache to frameworks (See PR #100). If you don't mind, would you please rebuild your PR on top of the Framework branch, the branch which tracks this PR?

So the plan is to add a framework target for tvOS, with bitcode enabled, did I understand well?

For iOS, I'd rather not enabling bitcode by default. I mean, I don't want to force users to use bitcode unless it is mandatory (tvOS, watchOS).

groue commented 9 years ago

BTW, #100 has removed the Makefile entirely, and relies on CocoaPods or Carthage for the building part.

groue commented 9 years ago

@aaronbrethorst, are you still there?

Would you please try the tvOS branch? It also contains a demo app that may help you importing the GRMustache framework in your project.

aaronbrethorst commented 9 years ago

Hi, yeah, sorry. I've been neck-deep in getting my tvOS app finished up. I should be able to get things moving in 2-3 days. Sorry for the delay :(

groue commented 9 years ago

Don't apologize, we are are all working, and this also explain the delay in my own answer to your PR :-) Just tell me if the tvOS branch works for you. Beware: GRMustache is no longer a static lib, but a framework now.