search

groue / GRMustache

Flexible and production-ready Mustache templates for MacOS Cocoa and iOS
http://mustache.github.com/
MIT License
1.44k stars 190 forks source link

Add Carthage support #106

Closed marbetschar closed 8 years ago

marbetschar commented 8 years ago

Adding Carthage support would be very cool!

Right now when I check out the project using Carthage, I receive the following error message:

*** Skipped building GRMustache due to the error:
Dependency "GRMustache" has no shared framework schemes for any of the platforms: iOS
marbetschar commented 8 years ago

Seems like the master branch works since there is a shared GRMustache framework scheme in it:

github "groue/GRMustache" "master"

But I'm quite unsure if the master branch is safe for production use?? Any better options?

groue commented 8 years ago

Hello @marbetschar

I've been lazy completing the work on the framework support, I'm sorry.

groue commented 8 years ago

Is there a way for you to avoid the framework for now, or do you really need it?

marbetschar commented 8 years ago

Hi @groue!

Unfortunately I really need the framework :(

As up now I was able to build and include it into my project using Carthage, so master seems to work at first sight - without going into any testing yet.

So I'm wondering what you mean with "you weren't able to complete the work on the framework support"? And if it's save to use the framework in production?

groue commented 8 years ago

Unfortunately I really need the framework :(

No problem, we're in 2016 now - static libs are so 2010 :-)

As up now I was able to build and include it into my project using Carthage, so master seems to work at first sight - without going into any testing yet. So I'm wondering what you mean with "you weren't able to complete the work on the framework support"? And if it's save to use the framework in production?

I have been working on a framework-only branch, with improved compatibility with GRMustache.swift. This work is stalled, that's what I'm referring to.

But if you were able to build GRMustache with Carthage, I do not expect that you have any problem. Just open an issue in this case!

marbetschar commented 8 years ago

Ok, cool! Thanks!!!

groue commented 8 years ago

Happy Mustache!