groue / GRMustache

Flexible and production-ready Mustache templates for MacOS Cocoa and iOS
http://mustache.github.com/
MIT License
1.44k stars 190 forks source link

Build and install isn't quite as described, here's what I did. #39

Closed peterbmarks closed 11 years ago

peterbmarks commented 11 years ago

To add GRMustache to my iOS project I needed to:

After that all was good. Perhaps I'm missing the right documentation?

groue commented 11 years ago

HI Peter! You got it right, some don't solve this puzzle :-)

Meanwhile, the README was there under your eyes, telling:

How To For iOS development, add include/GRMustache.h and lib/libGRMustache6-iOS.a to your project.

(the pre-built static library is part of the distribution).

GRMustache is abundantly documented, maybe too much. Don't miss the full story, starting under the word documentation

Happy Mustache!

peterbmarks commented 11 years ago

Thanks groue,

My point is that your documentation which says "For iOS development, add include/GRMustache.h and lib/libGRMustache6-iOS.a to your project." is not enough to build successfully.

Peter

groue commented 11 years ago

Peter, it should be enough to build successfully, since the wording implies so.

What error do you get?

peterbmarks commented 11 years ago

Firstly, GRMustache.h has:

import "GRMustacheAvailabilityMacros.h"

Secondly, I followed your instruction to pull from github but the source is missing jrswizzle.h and jrswizzle.m which I got from one of your other projects.

groue commented 11 years ago

Oh, so you haven't seen any problem. You just infer there would be some.

Actually you are wrong.

Firstly, GRMustache.h has: #import "GRMustacheAvailabilityMacros.h"

Importing the single GRMustache.h is enough, since all other headers lies in the same directory. Xcode only care about search paths, not individual files. Import all of them if you want, in doesn't harm. Importing the sole GRMustache.h is just as OK.

I followed your instruction to pull from github.

Yes, and you should have followed them more thoroughly. You have been needing the jrswizzle files because you ran the make command, for some reason I don't know.

I'm sorry you got misled by some false assumptions. However, the README wording, "add include/GRMustache.h and lib/libGRMustache6-iOS.a to your project" is 100% efficient for using GRMustache.

peterbmarks commented 11 years ago

My foolish mistake was to copy the header and library to my project. Sorry to waste your time. Thank you for the good work on this project.

groue commented 11 years ago

No you haven't! I'm updating the README to avoid other people making the same mistake - now that the root cause of the issue has been found :-)

groue commented 11 years ago

I hope the new wording will avoid sending other users in the same grey area you have been thrown in. Thanks for opening your issue, Peter.