search

groue / GRMustache

Flexible and production-ready Mustache templates for MacOS Cocoa and iOS
http://mustache.github.com/
MIT License
1.44k stars 190 forks source link

Added missing @autoreleasepool to +load method. #48

Closed oleganza closed 11 years ago

oleganza commented 11 years ago

When I launch my app on iPad1 with iOS 5.1.1 there are system messages about missing autorelease pool. This patch fixes the problem.

objc[3907]: Object 0x864190 of class GRMustacheCapitalizedFilter autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug objc[3907]: Object 0x8590f0 of class GRMustacheLowercaseFilter autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug objc[3907]: Object 0x865780 of class GRMustacheUppercaseFilter autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug objc[3907]: Object 0x8657d0 of class GRMustacheBlankFilter autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug objc[3907]: Object 0x8658b0 of class GRMustacheEmptyFilter autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug objc[3907]: Object 0x8659e0 of class GRMustacheLocalizer autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug objc[3907]: Object 0x865b00 of class GRMustacheHTMLEscapeFilter autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug objc[3907]: Object 0x865a40 of class NSCFDictionary autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug objc[3907]: Object 0x85ae10 of class GRMustacheJavascriptEscaper autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug objc[3907]: Object 0x865cc0 of class NSCFDictionary autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug objc[3907]: Object 0x865d70 of class GRMustacheURLEscapeFilter autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug objc[3907]: Object 0x865db0 of class __NSCFDictionary autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug objc[3907]: Object 0x865e20 of class __NSCFDictionary autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug objc[3907]: Object 0x866250 of class GRMustacheContext autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug

groue commented 11 years ago

Thanks Oleg! This is a bugfix: the version needs to be incremented. Can you please remove the a04fe2f commit, so that I can accept the PR?

groue commented 11 years ago

Fever had me write the comment above. I'll take care of it, thanks Oleg.

groue commented 11 years ago

Let's go and ship 6.4.1!

oleganza commented 11 years ago

No probs ;-)