search

groue / GRMustache

Flexible and production-ready Mustache templates for MacOS Cocoa and iOS
http://mustache.github.com/
MIT License
1.44k stars 190 forks source link

Added missing newlines to EOF in several public headers. #75

Closed zygoat closed 10 years ago

zygoat commented 10 years ago

When imported in a project with GCC_WARN_ABOUT_MISSING_NEWLINE = YES, a couple of headers would fail on this warning. Also enabled this warning in the local project for verification.

(I discovered this with GRMustache brought in via CocoaPods and running a production build with a set of strict warnings enabled.)

groue commented 10 years ago

Thanks, Ben!

I don't quite know if it deserves a new version, what do you think?

zygoat commented 10 years ago

Thanks Gwendal! (this was my first effort at a Github PR, and apparently successful, yay!)

I agree; it's a pretty minor thing so I don't think it calls for a new version. It was easy for me to work around locally by just disabling that warning for now in my release build.

b

groue commented 10 years ago

You are welcome :-) Your code will ship in the next release. Happy github and happy Mustache!